fix: Error on empty min/max call #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
approved these changes
Jun 28, 2019
nschonni
force-pushed
the
fix--Error-on-empty-min/max-call
branch
from
f00094d
to
948f126
Compare
nex3
requested changes
Jul 1, 2019
There was a problem hiding this comment.
Please add "See sass/sass-spec#1420" to the PR message and re-run the specs to verify that this actually fixes the specs.
|
@nex3 added the message and reopened the PR |
nex3
approved these changes
Jul 1, 2019
|
Thanks! |
|
Landing this and other spec-affecting PRs without landing the corresponding spec changes has broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#1420
Closes #2914