Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mix): Align argurment names to color1/color2 #2934

Merged
merged 1 commit into from
Jul 15, 2019
Merged

fix(mix): Align argurment names to color1/color2 #2934

merged 1 commit into from
Jul 15, 2019

Conversation

nschonni
Copy link
Collaborator

@nschonni nschonni commented Jun 28, 2019 •
edited
Loading

@nschonni nschonni force-pushed the fix(mix)--Align-argurment-names-to-color1/color2 branch from d45d1ba to 3844174 Compare June 28, 2019 03:46
@nschonni nschonni mentioned this pull request Jun 28, 2019
Merged
@nex3 nex3 self-requested a review July 1, 2019 21:56
@nex3
Copy link
Contributor

nex3 commented Jul 1, 2019

Same request as for #2933: please link this to the sass-spec PR

@nschonni nschonni closed this Jul 1, 2019
@nschonni nschonni reopened this Jul 1, 2019
@nschonni
Copy link
Collaborator Author

nschonni commented Jul 1, 2019

@nex3 looks like it passed after updating and re-opening

nex3
nex3 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please wait to submit until you get a review from a LibSass maintainer.

@nschonni
Copy link
Collaborator Author

nschonni commented Jul 2, 2019

Yup, I don't like to land my own stuff 😄

@nschonni nschonni requested a review from mgreter July 9, 2019 02:38
mgreter
mgreter approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgreter mgreter merged commit c81a8e5 into sass:master Jul 15, 2019
@nschonni nschonni deleted the fix(mix)--Align-argurment-names-to-color1/color2 branch July 15, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

@mgreter mgreter mgreter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mix() color arguments have the wrong names
3 participants
@nschonni @nex3 @mgreter