Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error on non-int str-insert index #2945

Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: Error on non-int str-insert index #2945

merged 1 commit into from
Jul 26, 2019

Conversation

nschonni
Copy link
Collaborator

@nschonni
Copy link
Collaborator Author

@mgreter I tried swapping the double to an int, but that didn't work out 😝
Hope this makes sense

@nschonni nschonni closed this Jul 17, 2019
@nschonni nschonni reopened this Jul 17, 2019
@nschonni nschonni force-pushed the fix--Error-on-non-int-str-insert-index branch from 44e0ce9 to 1e23b4d Compare July 18, 2019 05:43
@nschonni nschonni requested a review from mgreter July 19, 2019 00:30
@nschonni
Copy link
Collaborator Author

@mgreter should I port over you "assertInt" instead?

@mgreter
Copy link
Contributor

mgreter commented Jul 21, 2019

Don't mind, the "invertInt" is part of a WIP branch ...

mgreter
mgreter approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nschonni nschonni merged commit 996dbb3 into sass:master Jul 26, 2019
@nschonni nschonni deleted the fix--Error-on-non-int-str-insert-index branch July 26, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgreter mgreter mgreter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

str-insert() should require an integer index
2 participants
@nschonni @mgreter