Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str-insert() should require an integer index #2921

Closed
nex3 opened this issue Jun 25, 2019 · 0 comments · Fixed by #2945
Closed

str-insert() should require an integer index #2921

nex3 opened this issue Jun 25, 2019 · 0 comments · Fixed by #2945
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 25, 2019

str-insert("", "", 0.5) should throw an error because $index isn't an integer. Instead in LibSass it returns "".
@nex3 nex3 added the Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem label Jun 25, 2019
nschonni added a commit to nschonni/libsass that referenced this issue Jul 17, 2019
@nschonni
fix: Error on non-int str-insert index
44e0ce9 
See sass/sass-spec#1439
Closes sass#2921
@nschonni nschonni mentioned this issue Jul 17, 2019
Merged
nschonni added a commit to nschonni/libsass that referenced this issue Jul 18, 2019
@nschonni
fix: Error on non-int str-insert index
1e23b4d 
See sass/sass-spec#1439
Closes sass#2921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Error on non-int str-insert index nschonni/libsass
1 participant
@nex3