Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Removes MinGW from cache #944

Merged
merged 2 commits into from
Mar 17, 2015
Merged

CI: Removes MinGW from cache #944

merged 2 commits into from
Mar 17, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 14, 2015

  • Repo: Adds VS files to .gitignore.

@mgreter mgreter added the Build label Mar 15, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 8a62662 on am11:master into dea27e5 on sass:master.

@mgreter
Copy link
Contributor

mgreter commented Mar 15, 2015

LGTM and CI seems to agree 😄

@xzyfer
Copy link
Contributor

xzyfer commented Mar 15, 2015

LGTM! also...

28 min 53 sec
😭

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 7e2802f on am11:master into dea27e5 on sass:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 7e2802f on am11:master into dea27e5 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 409cc12 on am11:master into dea27e5 on sass:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 409cc12 on am11:master into dea27e5 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 63ab83f on am11:master into dea27e5 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 11bbb66 on am11:master into dea27e5 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 11bbb66 on am11:master into dea27e5 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 76b5ef7 on am11:master into dea27e5 on sass:master.

@am11 am11 changed the title CI: Enable debug test on AppVeyor CI: Removes MinGW from cache Mar 17, 2015
@am11
Copy link
Contributor Author

am11 commented Mar 17, 2015

I have changed the title of this issue. The debug failure syndrome was back.

But the rest of the changes will boost the performance from ~6 mins to ~2 mins per build.

@xzyfer, please merge it so all future commits get compiled quickly (the MinGW jobs). :)

@am11
Copy link
Contributor Author

am11 commented Mar 17, 2015

@mgreter, that comment suggests that there were assertion errors when running the sassc command. Can you tell how did you diagnose it? I couldn't find it in the output. Is there a (hidden) verbose switch in sassc?

@xzyfer
Copy link
Contributor

xzyfer commented Mar 17, 2015

😍 😍 😍

@xzyfer
Copy link
Contributor

xzyfer commented Mar 17, 2015

Is this ready to go @am11 ?

@am11
Copy link
Contributor Author

am11 commented Mar 17, 2015

Yes @xzyfer! Debug can wait. :)

xzyfer added a commit that referenced this pull request Mar 17, 2015
CI: Removes MinGW from cache
@xzyfer xzyfer merged commit 4217540 into sass:master Mar 17, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Mar 17, 2015

💥 great work!

@mgreter
Copy link
Contributor

mgreter commented Mar 17, 2015

@am11 it simply did not complete the spec tests in debug mode, so I simply switched that off! Seems like we have fixed it in the mean time and you were the first one to stumble up on it!

@am11
Copy link
Contributor Author

am11 commented Mar 17, 2015

@mgreter, it was working when I opened this PR and now it starting to fail again: https://ci.appveyor.com/project/sass/libsass/build/1.0.303, so I reverted back that line with echo prefix. I don't know why it was working before and why failing now. But the comment there suggests that it fails with assertion failure, on running tests with debug configuration.

Perhaps, get some verbose output from sassc to check where the Debug build goes all mute for hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants