Add support for Node 12

sass · Apr 25, 2019 · da10866 · da10866
1 parent 0f86a0a
commit da10866
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -17,6 +17,12 @@ jobs:
     - stage: platform-test
       node_js: "node"
       os: osx
+    - stage: platform-test
+      node_js: "11"
+      os: linux
+    - stage: platform-test
+      node_js: "11"
+      os: osx
     - stage: platform-test
       node_js: "10"
       os: linux

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## v4.12.0
+
+https://github.com/sass/node-sass/releases/tag/v4.12.0
+
 ## v4.11.0
 
 https://github.com/sass/node-sass/releases/tag/v4.11.0

diff --git a/README.md b/README.md
@@ -4,6 +4,7 @@
 
 NodeJS  | Minimum node-sass version | Node Module
 --------|--------------------------|------------
+Node 12 | 4.12+                    | 72
 Node 11 | 4.10+                    | 67
 Node 10 | 4.9+                     | 64
 Node 8  | 4.5.3+                   | 57

diff --git a/appveyor.yml b/appveyor.yml
@@ -73,6 +73,9 @@
       - nodejs_version: 11
         GYP_MSVS_VERSION: 2015
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
+      - nodejs_version: 12
+        GYP_MSVS_VERSION: 2015
+        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
 
   install:
     - ps: Install-Product node $env:nodejs_version $env:platform
@@ -166,7 +169,10 @@
       - nodejs_version: 11
         GYP_MSVS_VERSION: 2015
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-
+      - nodejs_version: 12
+        GYP_MSVS_VERSION: 2015
+        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
+
   install:
     - ps: Install-Product node $env:nodejs_version $env:platform
     - node --version

diff --git a/lib/extensions.js b/lib/extensions.js
@@ -77,6 +77,7 @@ function getHumanNodeVersion(abi) {
     case 59: return 'Node.js 9.x';
     case 64: return 'Node.js 10.x';
     case 67: return 'Node.js 11.x';
+    case 72: return 'Node.js 12.x';
     default: return false;
   }
 }

diff --git a/src/create_string.cpp b/src/create_string.cpp
@@ -5,7 +5,7 @@
 
 char* create_string(Nan::MaybeLocal<v8::Value> maybevalue) {
   v8::Local<v8::Value> value;
-  
+
   if (maybevalue.ToLocal(&value)) {
     if (value->IsNull() || !value->IsString()) {
       return 0;
@@ -14,7 +14,7 @@ char* create_string(Nan::MaybeLocal<v8::Value> maybevalue) {
     return 0;
   }
 
-  v8::String::Utf8Value string(value);
+  Nan::Utf8String string(value);
   char *str = (char *)malloc(string.length() + 1);
   strcpy(str, *string);
   return str;