Binary test fails in master after the commit 22c560c70a

[chivorotkiv]

Hi.
Something was changed in build.js in the commit: 22c560c70a.

Tested on MacOS:

• Before: binary is fine
• After: problem with the binary, compile it with c++.

Also I have tested it on Windows 7:

• Before: binary exists, binary is fine, no c++ compilation
• After: binary exists, problem with the binary, c++ compilation passes successfully.

But if the binaries weren't changed and were valid before, they should also be valid after the change of build.js

/cc @xzyfer

[xzyfer]

I actually noticed this last night. Thanks for digging in and finding the
offending commit. I'll take a look shortly.
On 31 Mar 2016 6:30 PM, "chivorotkiv" notifications@github.com wrote:

Hi.
Something was changed
https://monosnap.com/file/CtV5ucpfvNicRdax84ZY4qs5hVKMMu.png in build.js
in the commit: 22c560c
22c560c
.

Tested on MacOS:

• Before: binary is fine
  https://monosnap.com/file/9sSNfnsxyLJVkmJeFQGFnTk4U04BcY.png
• After: problem with the binary
  https://monosnap.com/file/8Ob2CJrhpBDtVcPReEQ297m9zAyhhm.png,
  compile it with c++.

Also I have tested it on Windows 7:

• Before: binary exists, binary is fine, no c++ compilation
• After: binary exists, problem with the binary, c++ compilation
  passes successfully.

But if the binaries weren't changed and were valid before, they should
also be valid after the change of build.js

/cc @xzyfer https://github.com/xzyfer

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1434