-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 7 support #1766
Comments
The AppVeyor update is scheduled for the 30th. @am11 could I possibly bother you to build the Windows Node 7 binaries for 3.10.1? |
Hey @xzyfer, :) 5906 passing (2m)
322 pending
2 failing
1) cli node-sass sass/ --output css/ should not error if output directory is a symlink:
Error: EEXIST: file already exists, mkdir 'C:\Users\Adeel\Source\Repos\node-sass\test\fixtures\input-directory\css'
at Object.fs.mkdirSync (fs.js:846:18)
at Context.<anonymous> (C:\Users\Adeel\Source\Repos\node-sass\test\cli.js:582:10)
at callFnAsync (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runnable.js:349:8)
at Test.Runnable.run (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runnable.js:301:7)
at Runner.runTest (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:422:10)
at C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:528:12
at next (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:342:14)
at C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:352:7
at next (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:284:14)
at Immediate.<anonymous> (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:320:5)
2) cli node-sass --follow --output output-dir input-dir should compile with the --follow option:
Error: EEXIST: file already exists, mkdir 'C:\Users\Adeel\Source\Repos\node-sass\test\fixtures\follow\input-dir'
at Object.fs.mkdirSync (fs.js:846:18)
at Context.<anonymous> (C:\Users\Adeel\Source\Repos\node-sass\test\cli.js:623:10)
at callFnAsync (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runnable.js:349:8)
at Test.Runnable.run (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runnable.js:301:7)
at Runner.runTest (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:422:10)
at C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:528:12
at next (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:342:14)
at C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:352:7
at next (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:284:14)
at Immediate.<anonymous> (C:\Users\Adeel\Source\Repos\node-sass\node_modules\mocha\lib\runner.js:320:5)
npm ERR! Test failed. See above for more details. Is it still good to go? I will send a PR to binaries repo afterwards. |
Life saver @am11. I think those tests are due to the test suite not cleaning up after itself properly. Nothing to worry about. |
Just giving a heads up that ArchLinux updated to 7.0.0 today. So there might be an influx of Linux devs opening/adding-to issues in the next couple days if a new release doesn't happen. Any eta? Regardless thanks for maintaining one of the most important packages in the Node-ecosystem. I'll just |
Looks like node 7 is available on appveyor: http://help.appveyor.com/discussions/suggestions/1132-make-nodejs-7-available |
Thanks for the heads up @nikolowry. It's worthing noting that the latest node-sass will install and work perfectly fine on Node 7. This is largely a meta issue so we know when to update some copy and CI config. |
@xzyfer I didn't initially So just a user-error! Thanks again |
@nikolowry correct. You should always do a fresh install when change Node version or environments (i.e. mounting into a container). This is because native extensions are compiled against the current os and Node version. |
@anaibol latest 3.11.1 is there already https://www.npmjs.com/package/node-sass |
Cool! It says "Supported Node.js versions 0.10, 0.12, 1, 2, 3, 4, 5, and 6." |
The latest v3.11.1 release supports Node.js 7 on all platforms except FreeBSD. See GitHub release notes. |
Fixed a build issue on Node 7 caused by the following issue: sass/node-sass#1766
Fixed a build issue on Node 7 caused by the following issue: sass/node-sass#1766
Fixed a build issue on Node 7 caused by the following issue: sass/node-sass#1766
Currently blocked on AppVeyor supporting Node 7.
The text was updated successfully, but these errors were encountered: