-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 8.4 in Node 14.6+ changed the toString behaviour for sass.types #2972
Comments
Does this mean the latest release doesn't work on the latest node 14?
…On Sun, 27 Sep 2020, 12:21 pm Nick Schonning, ***@***.***> wrote:
- NPM version (npm -v): 6.14.8
- Node version (node -v): 14.12.0, but anything above 14.5.0 has this
- Node Process (node -p process.versions):
{
node: '14.12.0',
v8: '8.4.371.19-node.16',
uv: '1.39.0',
zlib: '1.2.11',
brotli: '1.0.9',
ares: '1.16.0',
modules: '83',
nghttp2: '1.41.0',
napi: '7',
llhttp: '2.1.2',
openssl: '1.1.1g',
cldr: '37.0',
icu: '67.1',
tz: '2020a',
unicode: '13.0'
}
- Node Platform (`node -p process.platform`): win32, but all in CI as well
- Node architecture (`node -p process.arch`): x64, but all in CI as well
- node-sass version (`node -p "require('node-sass').info"`):
- npm node-sass versions (`npm ls node-sass`): 4.14.1
<!--
When encountering a syntax, or compilation issue:
- Please note that we cannot backport fixes to old versions, so ensure that you are running the latest release https://github.com/sass/node-sass/releases
- Search for duplicate or closed issues https://github.com/sass/node-sass/issues?utf8=%E2%9C%93&q=is%3Aissue
- Validate with http://sassmeister.com/ that the code works with Ruby Sass, then open an issue on `LibSass` https://github.com/sass/LibSass/issues/new
Sorry you didn't have the experience you expected.
-->
Upstream node issue nodejs/node#35365 was closed as a wont-fix, as the behaviour is a change in v8.
The solution seems to be set the @@toStringTag or https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2972>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENSWBMV7IZN5P3O45V3WTSH2OTJANCNFSM4R3IONZA>
.
|
It still runs, but the the var t = sass.types.Color();
assert.equal(t.toString(), '[object SassColor]'); I don't think this makes a real functionally difference for the runtime, except maybe some extensions or advanced usage. If we can't figure out the fix, then the tests could possibly be disabled, but I think trying to find a fix would be a good idea first |
Yeah sounds like the test is probably not useful in its current form. Happy
to remove it.
…On Sun, 27 Sep 2020, 12:32 pm Nick Schonning, ***@***.***> wrote:
It still runs, but the the toString in the following now just returns [object
Object], rather than [object SassColor] like it was previously, which is
way CI was failing on 14.6 and above
var t = sass.types.Color();
assert.equal(t.toString(), '[object SassColor]');
I don't think this makes a real functionally difference for the runtime,
except maybe some extensions or advanced usage.
If we can't figure out the fix, then the tests could possibly be disabled,
but I think trying to find a fix would be a good idea first
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2972 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENSWEC4KRZJLEMUEEYFD3SH2P3DANCNFSM4R3IONZA>
.
|
Related to tracking issue sass#2972
Got a hint over on the node issue that lead me over to here https://hyperandroid.com/2020/02/12/javascript-native-wrappers-in-v8-part-i/ |
This call
|
npm -v
): 6.14.8node -v
): 14.12.0, but anything above 14.5.0 has thisnode -p process.versions
):node -p process.platform
): win32, but all in CI as wellnode -p process.arch
): x64, but all in CI as wellnode -p "require('node-sass').info"
):npm ls node-sass
): 4.14.1Upstream node issue nodejs/node#35365 was closed as a wont-fix, as the behaviour is a change in v8.
The solution seems to be set the @@toStringTag or https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag
The text was updated successfully, but these errors were encountered: