Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Repo: Adds .gitattributes #760

Merged
merged 1 commit into from
Mar 14, 2015
Merged

Repo: Adds .gitattributes #760

merged 1 commit into from
Mar 14, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 13, 2015

Issue URL: #758.

//cc @mgreter

@kevva
Copy link
Member

kevva commented Mar 13, 2015

This feels like something that should be set on the user level imo.

@am11
Copy link
Contributor Author

am11 commented Mar 13, 2015

@kevva, it shouldn't be part of repo?

@kevva
Copy link
Member

kevva commented Mar 13, 2015

Well, ideally, contributors would have this setup in their editors/gitconfig, but I guess that's not always the case.

@xzyfer
Copy link
Contributor

xzyfer commented Mar 14, 2015

http://editorconfig.org/ might also be worth a look

@xzyfer
Copy link
Contributor

xzyfer commented Mar 14, 2015

👍

@mgreter
Copy link
Contributor

mgreter commented Mar 14, 2015

@kevva IMO it's a must to have a .gitattributes file for projects that are intended to work across multiple architectures. The file @am11 used as the base here has been in use by me since a few years, and I didn't just add it for the "fun" of adding it! The libsass team faces the same issue with the spec tests, since they currently are checked out either with \r\n or \n, according to the running OS. The spec-runner currently needs to normalize these linefeeds before comparing the results. In case of libsass this is actually desired, since we should use \r\n as the default linefeed when running on windows!

@am11 I guess you added the correct option for the file type that got mangled with the wrong line ending!

@am11
Copy link
Contributor Author

am11 commented Mar 14, 2015

@mgreter, forgot to add node-sass (the main node entry-point for CLI) itself. :)

@xzyfer, the .editorconfig is already setup for this repo. In VS, it even gives me intellisense in .editorconfig file due to this editorconfig/editorconfig-visualstudio#12! It seems like git was normalising all files because lack of .gitattributes. I think npm can also use something like .npmattributes to address npm/npm#2097.

@am11 am11 modified the milestone: 3.0 Mar 14, 2015
@am11 am11 removed the up-for-grabs label Mar 14, 2015
am11 added a commit that referenced this pull request Mar 14, 2015
Repo: Adds .gitattributes
@am11 am11 merged commit 2c88e9c into sass:master Mar 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants