Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert(a === b) => assert.strictEqual(a, b) #1307

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Conversation

saper
Copy link
Member

@saper saper commented Dec 19, 2015

When the test fails, we are getting actual
values in the error message instead of

+ true
- false

When the test fails, we are getting actual
values in the error message instead of

+ true
= false
@saper saper added this to the next.patch milestone Dec 20, 2015
@saper saper self-assigned this Dec 20, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Dec 22, 2015

Nice.

xzyfer added a commit that referenced this pull request Dec 22, 2015
Use assert.strictEqual in tests for better error output
@xzyfer xzyfer merged commit 7128b45 into sass:master Dec 22, 2015
@xzyfer xzyfer modified the milestone: next.patch Sep 4, 2016
Friendly-users referenced this pull request in Friendly-users/node-sass Jul 9, 2024
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants