This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Handle sass.NULL returned from the importer via done() #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
fix/importer-async-null
branch
from
3778801
to
620b62e
Compare
Whenever done() is called we should check for the sass.NULL value as well. While here, allow calling done(null) to anticipate removal of the sass.NULL one day. Fixes sass#1296
xzyfer
force-pushed
the
fix/importer-async-null
branch
from
620b62e
to
99dc18c
Compare
|
Since this doesn't introduce any BC breaks I'm 🚢 |
xzyfer
added a commit
that referenced
this pull request
Dec 27, 2015
Handle sass.NULL returned from the importer via done()
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Improve function call return value handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever done() is called we should check for the sass.NULL
value as well.
While here, allow calling done(null) to anticipate
removal of the sass.NULL one day.
Closes #1308
Fixes #1296