Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Bump npm deps #1321

Merged
merged 1 commit into from
Dec 28, 2015
Merged

Bump npm deps #1321

merged 1 commit into from
Dec 28, 2015

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Dec 27, 2015

get-stdin wasn't bumped to ^5 because it introduced a breaking
change which would require use to drop support for node 0.10 or
add a promise library just for this module.

get-stdin wasn't bumped to ^5 because it introduced a breaking
change which would require use to drop support for node 0.10 or
add a promise library just for this module.
@xzyfer xzyfer self-assigned this Dec 27, 2015
@xzyfer xzyfer added this to the next.patch milestone Dec 27, 2015
xzyfer added a commit that referenced this pull request Dec 28, 2015
@xzyfer xzyfer merged commit 23d5ba5 into sass:master Dec 28, 2015
@xzyfer xzyfer deleted the feat/bump-npm-deps branch December 28, 2015 02:22
@bradchesney79
Copy link

Any particular reason gaze didn't get a bump? node-sass:gaze ^0.5.1-->0.5.2(0.6.x available, minor bump to globule):globule 0.1.0(0.2.0 available, results in major bump to lodash):lodash . I tried doing it myself on the version gulp-sass uses-- TravisCI only builds correctly for node v0.10.x . node v0.10.41 and npm@latest is what I used for 'npm test' and the tests pass...

I looked at your TravisCI builds for node-sass which look ::borat;very nice:: and mine... not so much.

It worries me that node-sass only installs correctly for me on node v0.10.x (v0.10.41 was successful specifically). TravisCI only passes for the same v0.10.x for me. Your TravisCI runs pass from top to bottom...

I pull requested my minor bump of gaze for node-sass to the wrong repo/branch this morning. But, pull request 2 ready to fire off.

Any advice for better regression testing on my part? This thing is awesome-- and more complicated than most of the stuff I work on.

I am running kubuntu 14.something (E530) and OS X El Capitan (bxc470-mbpr) -- both with nvm (currently at 0.10.41 for both system and nvm) and the latest npm.

I've appended the steps and output of testing regarding the bump to a higher gaze dependency.

@bradchesney79
Copy link

"There is not enough information to act on. Please follow the steps in our troubleshooting guide.

Make sure to capture all output into a github gist. Do not post output here."

Noted.

https://gist.github.com/bradchesney79/9c27f7e7de899468e7ea -- E530

Strangely, works just fine on the MacBook for a recent version of node, v5.3.0. (Worrying that my LinuxFu is getting weak and/or eclipsed by my MacFu)

On the Mac all the tests pass the same for v5.3.0 as v0.10.41.

@xzyfer
Copy link
Contributor Author

xzyfer commented Dec 30, 2015

Gaze was not bumped because the latest dist-tag according to npm is 0.5.2

$ npm dist-tags ls gaze
latest: 0.5.2

Until this is change by the maintainer we will not bump to 0.6.

@bradchesney79
Copy link

Copy, thanks for the succinct and 100% acceptable answer.

@xzyfer xzyfer modified the milestone: next.patch Sep 4, 2016
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Clean up some code comments for accuracy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants