Use npmlog for all install script output #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
feat/clean-up-script-logging
branch
from
62246dd
to
ed885bc
Compare
In for a penny in for a pound. I also noticed that #1786 resulted in some funky looking console output. I've taken this opportunity to tidy up our install script output whilst maintaining the information useful for debugging install issues. ``` > node-sass@3.11.3 install /Users/xzyfer/Projects/Sass/upstream/node-sass > node scripts/install.js http node-sass install Downloading binary from https://github.com/sass/node-sass/releases/download/v3.11.3/darwin-x64-47_binding.node http node-sass install Download complete info node-sass install Binary saved at /Users/xzyfer/Projects/Sass/upstream/node-sass/vendor/darwin-x64-47/binding.node > node-sass@3.11.3 postinstall /Users/xzyfer/Projects/Sass/upstream/node-sass > node scripts/build.js info node-sass build Binary found at /Users/xzyfer/Projects/Sass/upstream/node-sass/vendor/darwin-x64-47/binding.node info node-sass build Testing binary info node-sass build Binary is fine > node-sass@3.11.3 prepublish /Users/xzyfer/Projects/Sass/upstream/node-sass > not-in-install && node scripts/prepublish.js || in-install ```
xzyfer
force-pushed
the
feat/clean-up-script-logging
branch
from
ed885bc
to
0f2e004
Compare
xzyfer
added a commit
that referenced
this pull request
Nov 15, 2016
xzyfer
added a commit
that referenced
this pull request
Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In for a penny in for a pound. I also noticed that #1786 resulted
in some funky looking console output. I've taken this opportunity to
tidy up our install script output whilst maintaining the information
useful for debugging install issues.