Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect quiet option in Node API #2268

Merged
merged 2 commits into from
Mar 4, 2018
Merged

Respect quiet option in Node API #2268

merged 2 commits into from
Mar 4, 2018

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Mar 4, 2018

  • Emit normal output as info not warn
  • Don't emit info output in quiet mode

Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the linked issue is asking about something else since Grunt wouldn't be calling through the bin

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 4, 2018

You're totally right. The issue is confusing.

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 4, 2018

I agree this isn't related the the tagged issue (now removed), but it still the correct behaviour.

@xzyfer xzyfer merged commit 78a74e9 into master Mar 4, 2018
@xzyfer xzyfer deleted the cli-info branch March 4, 2018 02:52
@RiZKiT
Copy link

RiZKiT commented Apr 16, 2018

@xzyfer Thanks a lot for the 'warn' > 'info' change, the useless warning output in our build process was always confusing.

It would be nice to change it here, too: https://github.com/sass/node-sass/blob/master/lib/render.js

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 18, 2018 via email

xzyfer added a commit that referenced this pull request Apr 24, 2018
This is an extension of #2268. Catches a few places missed the
first time around.
@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 24, 2018

Addressed in #2344.

xzyfer added a commit that referenced this pull request Apr 24, 2018
This is an extension of #2268. Catches a few places missed the
first time around.
@saper
Copy link
Member

saper commented Oct 17, 2019

While troubleshooting CLI watcher tests (for #2560 and #2479 I have noticed that this and #2344 has a bad side-effect.

Watcher messages go out now to standard output instead of to standard error.

This breaks the following (seldom) usage:

 node-sass --output-style compressed --watch main.scss

Our (currently skipped) watcher tests expect that CSS output will be delivered to stdout.

I have filed #2755 about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants