Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 11 support #2522

Merged
merged 5 commits into from Nov 4, 2018
Merged

Add Node 11 support #2522

merged 5 commits into from Nov 4, 2018

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Oct 23, 2018

Fixes #2521

@xzyfer xzyfer added the Node 11 label Oct 23, 2018
@xzyfer xzyfer self-assigned this Oct 23, 2018
@xzyfer xzyfer mentioned this pull request Oct 23, 2018
@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 23, 2018

Seeing a compilation failure on Linux builds

 g++-4.7 '-DNODE_GYP_MODULE_NAME=libsass' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DLIBSASS_VERSION="3.5.4"' -I/home/travis/.node-gyp/11.0.0/include/node -I/home/travis/.node-gyp/11.0.0/src -I/home/travis/.node-gyp/11.0.0/deps/openssl/config -I/home/travis/.node-gyp/11.0.0/deps/openssl/openssl/include -I/home/travis/.node-gyp/11.0.0/deps/uv/include -I/home/travis/.node-gyp/11.0.0/deps/zlib -I/home/travis/.node-gyp/11.0.0/deps/v8/include -I../src/libsass/include  -fPIC -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -std=gnu++1y -std=c++0x -fexceptions -frtti -MMD -MF ./Release/.deps/Release/obj.target/libsass/src/libsass/src/ast.o.d.raw   -c -o Release/obj.target/libsass/src/libsass/src/ast.o ../src/libsass/src/ast.cpp
g++-4.7: error: unrecognized command line option ‘-std=gnu++1y’

.travis.yml Show resolved Hide resolved
@saper
Copy link
Member

saper commented Oct 24, 2018

If gnu++1y is needed, then gcc 4.7 is too old.
https://github.com/nodejs/node/blob/v11.0.0/BUILDING.md#unixmacos says

gcc and g++ 4.9.4 or newer, or
clang and clang++ 3.4.2 or newer (macOS: latest Xcode Command Line Tools)

We need to keep the old compiler for the other systems. I wonder which systems we can no longer support on 11 due to this requirement.

@nschonni
Copy link
Contributor

@saper I fixed that error by making sure it had GCC 4.9 for 11.
It does look like FreeBSD 10 was dropped for Node 11 https://nodejs.org/en/blog/release/v11.0.0/ so that might affect your binary builds

@saper
Copy link
Member

saper commented Oct 24, 2018

Thanks, I noticed that - I am using 10 to build the modules but there is no problem to switch to 11 if needed. Fortunately a supported clang is available on both versions.

Yes, I have only seen the @xzyfer mails and after I checked the code I figured out it actually works. Thanks for fixing it.

@nschonni
Copy link
Contributor

np, and it probalby makes sense to keep building <11 on FreeBSD 10 if you have the capacity to keep it around. I'm not really sure if that makes sense in terms of how people upgrade the distros in the FreeBSD world.

@sass sass deleted a comment from assoft Oct 25, 2018
@xzyfer
Copy link
Contributor Author

xzyfer commented Nov 3, 2018

AppVeyor has added Node 11 support. We've begun the process of building the binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants