Suppress -std=c++0x option for zOS #2553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The njsc/c++ compiler used for Node.js on z/OS has C++11 support by default. The -std=c++0x option currently triggers a FSUM3210 error, hence, updating gyp files to suppress use of this option on the platform. Signed-off-by: Joran Siu <joransiu@ca.ibm.com>
|
@xzyfer don't think this hurts (event if we don't support zOS), but I'm wondering about the upstream libsass change to swap this old flag for the newer |
|
I need to validate we can still compile on CentOS 5 with this change. I
vaguely recall that's why this hasn't been made before.
We've made this change in LibSass so we should do it in v5 for sure.
…On Fri., 7 Dec. 2018, 1:21 pm Nick Schonning ***@***.*** wrote:
@xzyfer <https://github.com/xzyfer> don't think this hurts (event if we
don't support zOS), but I'm wondering about the upstream libsass change to
swap this old flag for the newer c++11 version
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2553 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWAvfq0m6kU6zYcUIHvNNq1olA53Yks5u2dCMgaJpZM4ZAzKF>
.
|
|
Around 3.5.0 (upgrade to node-gyp after 3.2.0) we have lost ability to build on CentOS 5. Therefore I believe we should drop this altogether, for all platforms. |
saper
added a commit
to saper/node-sass
that referenced
this pull request
Oct 21, 2019
Followup-to: sass#2553
|
These are dropped now for all platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The njsc/c++ compiler used for Node.js on z/OS has C++11 support by
default. The -std=c++0x option currently triggers a FSUM3210 error,
hence, updating gyp files to suppress use of this option on the
platform (similar to what's currently done for Windows).
Signed-off-by: Joran Siu joransiu@ca.ibm.com