Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Node 18 and 19 support and drop Node 17 #3257

Merged
merged 3 commits into from
Nov 9, 2022
Merged

feat: Node 18 and 19 support and drop Node 17 #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccce7e1
feat: Node 18 support
nschonni Apr 19, 2022
dad8865
feat: drop EOL Node 17
nschonni Jun 4, 2022
529d68a
feat: Node 19 support
nschonni Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/alpine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ jobs:
matrix:
node:
- 14
# Node 16 and 17 are perma-red for the tests right now
# Node 16+ are perma-red for the tests right now
# - 16
# - 17
# - 18
# - 19

steps:
- name: Install Alpine build tools
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
node:
- 14
- 16
- 17
- 18

include:
- node: 14
Expand All @@ -27,10 +27,14 @@ jobs:
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-18.04
- node: 17
- node: 18
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-18.04
os: ubuntu-20.04
- node: 19
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-20.04


steps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ jobs:
node:
- 14
- 16
- 17
- 18
- 19

steps:
- uses: actions/checkout@v3
Expand Down
13 changes: 3 additions & 10 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,21 @@ on:

jobs:
build:
runs-on: ${{ matrix.os }}
runs-on: windows-2019

strategy:
fail-fast: false
matrix:
node:
- 14
- 16
- 17
- 18
- 19

architecture:
- x64
- x86

include:
- node: 14
os: windows-2019
- node: 16
os: windows-2019
- node: 17
os: windows-2019

steps:
- uses: actions/checkout@v3

Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:

NodeJS | Supported node-sass version | Node Module
--------|-----------------------------|------------
Node 17 | 7.0+ | 102
Node 19 | 8.0+ | 111
Node 18 | 8.0+ | 108
Node 17 | 7.0+, <8.0 | 102
Node 16 | 6.0+ | 93
Node 15 | 5.0+, <7.0 | 88
Node 14 | 4.14+ | 83
Expand Down
6 changes: 5 additions & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,13 @@
- nodejs_version: 16
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- nodejs_version: 17
- nodejs_version: 18
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- nodejs_version: 19
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019


install:
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
Expand Down
2 changes: 2 additions & 0 deletions lib/extensions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ function getHumanNodeVersion(abi) {
case 88: return 'Node.js 15.x';
case 93: return 'Node.js 16.x';
case 102: return 'Node.js 17.x';
case 108: return 'Node.js 18.x';
case 111: return 'Node.js 19.x';
default: return false;
}
}
Expand Down