Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules: Updated submodules (#510) #511

Merged
merged 1 commit into from
Nov 5, 2014
Merged

Submodules: Updated submodules (#510) #511

merged 1 commit into from
Nov 5, 2014

Conversation

am11
Copy link
Contributor

@am11 am11 commented Nov 5, 2014

  • Additions in the binding.gyp.
  • Updated CLI test for line endings.
  • Updated Appveyor.yml as per @FeodorFitsner's
    suggestion.

* Additions in the binding.gyp.
* Updated CLI test for line endings.
* Updated Appveyor.yml as per @FeodorFitsner's
  suggestion.
@andrew
Copy link
Contributor

andrew commented Nov 5, 2014

Sweet! I'll be around all day today so we can ship a new release 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 403d6c1 on am11:master into dd0d743 on sass:master.

@am11 am11 mentioned this pull request Nov 5, 2014
@am11
Copy link
Contributor Author

am11 commented Nov 5, 2014

Awesome 👍

andrew added a commit that referenced this pull request Nov 5, 2014
Submodules: Updated submodules (#510)
@andrew andrew merged commit a4be152 into sass:master Nov 5, 2014
@kevva
Copy link
Member

kevva commented Nov 5, 2014

👍

@am11
Copy link
Contributor Author

am11 commented Nov 5, 2014

I have updated Windows binaries on node-sass-binaries. Please add Linux and Darwin binaries from respective platform. For Linux, please don't generate both x86/x64 binaries from one platform. We need one Linux x64 (or x86; doesn't matter) with node-x86 (ia32) and one with node-x64. Send commit from both separately (no mv'ing).

I know this sounds paranoid, but this way we would know for a fact that it's not our fault. (-8

@am11
Copy link
Contributor Author

am11 commented Nov 5, 2014

Just clone node-sass-binaries separately, delete the respective folder, npm install node-sass followed by node scripts/build -f and then npm test. Finally copy vendor/<binary-folder> to node-sass-binaries/.

@am11 am11 mentioned this pull request Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants