-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --watch
option for directories
#512
Conversation
Fix `--watch` option for directories
Nice work @kevva! |
Thanks. Guess we can ignore the 0.11 issues for now. There's an open issue about it on shama/gaze#145 and probably a fix in shama/gaze#151. |
Wow, thanks for a quick fix! Not working for me yet, though:
Same if I try with a dir as the argument. Ideas..? |
@jareware, |
And sure enough, it does, thanks! :) Still doesn't seem to watch recursively, though..? |
Perhaps with |
Okey, will PR. |
Thanks for your work on this @kevva. However, after playing around with it a bit in 1.2.1, I'm not sure the new behavior makes sense. For instance:
Note that changes in
Ruby sass also watches for changes in
Am I wrong in thinking that node-sass's watch behavior should more or less match that of Ruby sass? For reference, here are a couple of my previous comments on the topic: |
Oh, that's because it only renders the file defined in Not sure how we'd watch for imported files though. |
Switches out
node-watch
forgaze
since it's used more widely.Fixes #250 and #312.