Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Custom importer (#530) #576

Merged
merged 17 commits into from
Dec 18, 2014
Merged

Feature: Custom importer (#530) #576

merged 17 commits into from
Dec 18, 2014

Conversation

am11
Copy link
Contributor

@am11 am11 commented Dec 18, 2014

This addresses gh-530.

@am11
Importer: Uses libsass importers.
00057b7
@am11
Importer: Moves the setter inside condition.
3a9c84b
@am11
Code: Renames callback <-> success_callback.
fa595ff
@am11
libuv: Uses uv_async_send to dispatch callback.
cbcacc2 
Dispatches callback to uv_default_loop.
@am11
Importer-cb: Adds lock to acquire v8 main thread.
292e1ba
@am11
Importer: Moves mutex in context.
800738a
@am11
Importer: Fixes issue with casting.
1d597d5
@am11
Code: Cleanup and formatting.
670cc89
@am11
Importer: Sleep() before second locks.
b2ce0f6
@am11
Importer: Uses uv_cond to solve the puzzle.
2e82e70 
Credit goes to @txdv.
@am11
Importer: Destroys vars before leaving the scope.
f5a19be
@am11
Importer: Adds callback for asynchrony.
fd8c7f7
@am11
Upstream: Fetches latest libsass.
5afecaf
@am11
Importer: Adds importer support for renderSync.
eedc835 
* Adds code comments.
@am11
Importer: Adds support for previous.
b0013a0
@am11
Importer: Removes free context from Sync handlers.
3d035c3
@am11
Upstream: Updates spec to 3.1-apha equivalent mark
5a6bd67
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5a6bd67 on am11:importer into * on sass:master*.

@am11
Copy link
Contributor Author

am11 commented Dec 18, 2014

Yay! all tests are passing. 🎉
LGTM! 👍 :shipit: 😄

/cc @xzyfer, @mgreter, @andrew

am11 added a commit that referenced this pull request Dec 18, 2014
@am11
Merge pull request #576 from am11/importer
4bea070 
Feature: Custom importer (#530)
@am11 am11 merged commit 4bea070 into sass:master Dec 18, 2014
@am11 am11 mentioned this pull request Dec 19, 2014
Merged
3 tasks
@rvagg rvagg mentioned this pull request Jan 6, 2015
Closed
@am11 am11 deleted the importer branch March 22, 2015 14:28
@snyk-bot snyk-bot mentioned this pull request Mar 2, 2023
Open
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
@mgreter
Merge pull request sass#576 from mgreter/fix/build-older-gcc
c0e8af0 
Moves hash initialization to correct position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@am11 @coveralls @txdv @rvagg