-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarity to sourceMap option #606
Conversation
Changes Unknown when pulling f5d27d9 on jenius:readme into * on sass:master*. |
Developers are pretty normal humans (perhaps I am being little optimistic here) but the relative paths is quite a known concept, even outside the dev community. :)
However, when source-map option is set to a relative file path, we resolve the path with respect to the path of that of output file. This does not mean that the If the text in readme is not depicting the intended behavior, feel free to propose a better alternative. Thanks for the PR! 👍 A logical question: why don't we resolve sourcemap path against It is because it does not make sense to generate a source-map file without having the destination. Also, note that now we have embedded content option in source-map as well, so it should probably be a legit case to have not |
The fact that you had to write that lengthy of a comment to explain what it meant is exactly my point. Here's how I might reword it:
Does that seem correct? It makes more sense to me on initial reading. |
Yeah it looks fine. Just to be consistent with rest of the text:
|
Ok just rebased to include the modified text. 🎉 |
Thanks @Jenius! 👍 |
Whoo! 🎉 |
[WIP] Fixes and improves travis ci build
----- It is inappropriate to include political and offensive content in public code repositories. Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment. Please refrain from adding such content to public code repositories.
Very small PR that adds the fact that you must specify
outFile
as well in order to generate a source map.