Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iojs support #630

Merged
merged 2 commits into from
Jan 17, 2015
Merged

iojs support #630

merged 2 commits into from
Jan 17, 2015

Conversation

mnutt
Copy link
Contributor

@mnutt mnutt commented Jan 16, 2015

This allows node-sass to build on iojs. Tests suite passes with iojs 1.0.1 and node.js 0.10.31. Are there other node versions that should be tested as well?

Addresses #627.

One thing to note when manually rebuilding is that upstream node-gyp doesn't yet support iojs, so you need to make sure you're building using node-gyp bundled with iojs: nodejs/node#433

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0887f83 on mnutt:iojs-1.0.1 into 604ccf5 on sass:master.

@am11
Copy link
Contributor

am11 commented Jan 16, 2015

HI @mnutt, thanks for the contribution.

Can we test the build against io.js on Travis-CI?

@mnutt
Copy link
Contributor Author

mnutt commented Jan 16, 2015

@am11 unfortunately travis-ci doesn't yet have support for iojs, it looks like they're waiting for nvm to support it: travis-ci/travis-ci#3108

@am11
Copy link
Contributor

am11 commented Jan 16, 2015

@mnutt, brilliant. TravisCI can wait then. :)

@browniefed, if you can redo the Mac binary with these changes, I will merge this in for v2.0 (Edit: would require to delete node_module dir, npm install and then node-gyp rebuild). :)

@timoxley timoxley mentioned this pull request Jan 16, 2015
Closed
@am11
Copy link
Contributor

am11 commented Jan 16, 2015

@mnutt, on a separate note, can you please provide some pointers (or preferably an example of binding.gyp) on how to statically compile libstdc++ on Linux targets? LiibSass is using C++11 features and we are obliged to use gcc v4.6 (and GLIBCXX 3.49), while our target audience is mostly using CentOS 5.5+ (with GLIBCXX 2.14). That is a major show stopper for us ATM.

Related discussion #602 and #517.

@curiouslychase curiouslychase mentioned this pull request Jan 16, 2015
Closed
@browniefed
Copy link

@am11 will get to this some time this weekend.

@salzhrani
Copy link

+1

@am11
Copy link
Contributor

am11 commented Jan 17, 2015

@browniefed, excellent! So this should be merged then. :)

am11 added a commit that referenced this pull request Jan 17, 2015
@am11
Merge pull request #630 from mnutt/iojs-1.0.1
fb09e6b 
iojs support
@am11 am11 merged commit fb09e6b into sass:master Jan 17, 2015
@am11
Copy link
Contributor

am11 commented Jan 17, 2015

Thanks again @mnutt! 🎉

@am11 am11 mentioned this pull request Jan 17, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Jan 22, 2015
Closed
Friendly-users referenced this pull request in Friendly-users/node-sass Jul 9, 2024
@Friendly-users
No politics or offense in public code.
75139ea 
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mnutt @coveralls @am11 @browniefed @salzhrani