-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Produces identifiable binary name #657
Conversation
module.exports.getBinaryIdentifiableName = function() { | ||
return process.platform + '-' + | ||
process.arch + '-' + | ||
runtime + '-' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you factored out runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL yes and one more thing. Repushing now 😃
Will this approach handle things that aren't node or io, like atom shell? |
@xzyfer, I have not yet looked into atom shell yet. We can incorporate it later. However, we can add binary for io.js in node-sass-binaries v2.0.0. |
Yep! It's definitely a step forward |
@@ -8,11 +9,10 @@ var fs = require('fs'), | |||
*/ | |||
|
|||
function getBinding() { | |||
var name = process.platform + '-' + process.arch; | |||
var candidates = [ | |||
path.join(__dirname, '..', 'build', 'Release', 'binding.node'), | |||
path.join(__dirname, '..', 'build', 'Debug', 'binding.node'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because if you explicitly build Debug binary with node-gyp rebuild -d , then your primary intent is to debug that binary in debug mode
Build: Produces identifiable binary name
@xzyfer, tested with atom shell, it returns |
Nailed it 👍
|
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where
major
andminor
version belong tothe runtime.
Related Issue: #655.
//cc @xzyfer