Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Provides support for array of importers #832

Merged
merged 2 commits into from
Apr 5, 2015
Merged

Conversation

am11
Copy link
Contributor

@am11 am11 commented Apr 3, 2015

  • In order to skip the importer, user must
    return sass.types.NULL (or the shorter
    alias sass.NULL).
  • See the added test on usage.
  • Backward compatible: part of me want still
    wants to make it non-backward compatible
    because:
    • We can: in major version v3.0.
    • It will keep the API clean.
    • It will keep the docs clear: type of
      options.importers is array of functions.
  • Updates docs.

Issue URL: #821.

@am11
Copy link
Contributor Author

am11 commented Apr 3, 2015

@mgreter, @xzyfer, PTAL.

Also, thoughts on that breaking change note?

@am11
Copy link
Contributor Author

am11 commented Apr 4, 2015

@mgreter, going by perl-libsass and C-API documentation for importers, what is the purpose of last parameter srcmap?

@mgreter
Copy link
Contributor

mgreter commented Apr 4, 2015

@am11 if the loaded content has a sourcemap accociated, you should return the content of the sourcemap in that variable. We don't do anything with it yet, but in the future libsass should remap the resulting css to the provided source-map if possible.

@am11
Copy link
Contributor Author

am11 commented Apr 4, 2015

@mgreter, perfect! I will expose that feature to node-sass API in this PR then. :)

@mgreter
Copy link
Contributor

mgreter commented Apr 4, 2015

@am11 any ETA when you will release the next beta, so libsass can do another beta round too?

@am11
Copy link
Contributor Author

am11 commented Apr 4, 2015

@mgreter, I am almost ready. Can you please release a beta with the Sass_Compiler fixes, so our submodule points to libsass release, instead of some random commit hash? I will wind up the two open PRs soon and publish the next beta.

@mgreter
Copy link
Contributor

mgreter commented Apr 4, 2015

@am11 lets move that discussion to sass/libsass#1020 😉

@am11
Copy link
Contributor Author

am11 commented Apr 4, 2015

I have added the srcmap but lets keep it undocumented, since it doesn't have any effect on generated source-map.

I will do the final rebase once libsass next rc/beta is released..

am11 added a commit to am11/node-sass that referenced this pull request Apr 5, 2015
* In order to skip the importer, user must
  return `sass.types.NULL` (or the shorter
  alias `sass.NULL`).
* See the added test on usage.
* Backward compatible: part of me want still
  wants to make it non-backward compatible
  because:
  * We can: in major version v3.0.
  * It will keep the API clean.
  * It will keep the docs clear: type of
    `options.importers` is array of functions.
* Updates docs.

Issue URL: sass#821.
PR URL: sass#832.
am11 added 2 commits April 5, 2015 15:42
* Also updates dependencies versions.
* In order to skip the importer, user must
  return `sass.types.NULL` (or the shorter
  alias `sass.NULL`).
* See the added test on usage.
* Backward compatible: part of me want still
  wants to make it non-backward compatible
  because:
  * We can: in major version v3.0.
  * It will keep the API clean.
  * It will keep the docs clear: type of
    `options.importers` is array of functions.
* Updates docs.

Issue URL: sass#821.
PR URL: sass#832.
am11 added a commit that referenced this pull request Apr 5, 2015
API: Provides support for array of importers
@am11 am11 merged commit d12851b into sass:master Apr 5, 2015
@am11 am11 removed the up-for-grabs label Apr 5, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Update the native number function signatures to match Ruby sass 3.4.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants