Fix #775: Introduce SASS_BINARY_SITE environment variable #835
Conversation
|
We already have |
| @@ -89,8 +89,9 @@ function getBinaryUrl() { | |||
| return flags['--sass-binary-url'] || | |||
| package.nodeSassConfig ? package.nodeSassConfig.binaryUrl : null || | |||
There was a problem hiding this comment.
You can augment this with ['v', package.version, '/', sass.binaryName].join('')
There was a problem hiding this comment.
Sure we can; but this changes the meaning of SASS_BINARY_URL variable.
If somebody set it like this
SASS_BINARY_URL=http://somehost:8080/local/freebsd-x64-14_binding.node
it will no longer work, instead they would need to re-organize their files under 'v' + package.version to make this work again.
We can deprecate the SASS_BINARY_URL variable if we want, but let's give a new one a new name and let's warn users that the old one will no longer work.
This can be very confusing when somebody is upgrading a larger set of machines with npm...
There was a problem hiding this comment.
Agree. Then lets replace sassBinaryUrl with sassBinarySite (or preferably sassBinaryCdn as per the original requester #720) with the following precedence order:
- CLI argument
--sass-binary-cdn nodeSassConfig.sassBinaryCDNprocess.env.sassBinaryCDN
If none of them are found, it will fall back to default github URL.
There was a problem hiding this comment.
I think we should once migrate to something like https://github.com/dominictarr/rc or https://github.com/npm/npmconf so I'd love to have some consistent config variable names and camelCase makes it a bit difficult...
There was a problem hiding this comment.
@saper please read my previous comment again.
There was a problem hiding this comment.
Yes, I read. Btw. --sass-binary-url didn't work at all, it caused an exception (in current master).
saper
changed the title
saper
force-pushed
the
fix/775
branch
3 times, most recently
from
297f93c
to
a371de9
Compare
| * | ||
| * @api private | ||
| */ | ||
|
|
||
| function getBinaryUrl() { | ||
| return flags['--sass-binary-url'] || | ||
| package.nodeSassConfig ? package.nodeSassConfig.binaryUrl : null || | ||
| (package.nodeSassConfig ? package.nodeSassConfig.binaryUrl : null) || | ||
| process.env.SASS_BINARY_URL || |
There was a problem hiding this comment.
Now that we have sassBinarySite, we do not need sassBianryUrl and the test in api.js that goes with it.
|
You can port the related test from other PR. |
I'm not sure I have context here. Are you referring to #835 (comment)? If so I don't what PR he is referring to. Please fill me in. |
| ( | ||
| flags['--sass-binary-site'] || | ||
| (package.nodeSassConfig ? package.nodeSassConfig.binarySite : null) || | ||
| process.env.SASS_BINARY_SITE || 'https://github.com/sass/node-sass/releases/download' |
There was a problem hiding this comment.
Please move the default url into package.json
There was a problem hiding this comment.
If I'm reading this correct could we not simply default package.nodeSassConfig.binarySite to 'https://github.com/sass/node-sass/releases/download'?
Provide ability to locally mirror node-sass
binaries for various versions and platforms.
SASS_BINARY_SITE needs to be an URL pointing to
a collection of files organized like the Github
repository.
If SASS_BINARY_SITE is set to
http://myhost:8080/local/node-sass-bin/
then
http://myhost:8080/local/node-sass-bin/v3.0.0-beta.5/freebsd-x64-14_binding.node
should point to the FreeBSD 64 bit binary for node 0.12.0
The URL can be also specified as the --sass-binary-site
commandline option or in the package.json:
"nodeSassConfig": {
"binarySite": <url>
}
Remove --sass-binary-url and friends.
Also change priority and use package.json defaults
last, after command line arguments and the environment.
|
#847 appear to have this patch included. Closing this. |
Remove the non-standard compact function
Provide ability to locally mirror node-sass
binaries for various versions and platforms.
SASS_DIST_SITE needs to be an URL pointing to
a collection of files organized like the Github
repository.
If SASS_DIST_SITE is set to
http://myhost:8080/local/node-sass-bin
then
http://myhost:8080/local/node-sass-bin/v3.0.0-beta.4/freebsd-x64-14_binding.node
should point to the FreeBSD 64 bit binary for node 0.12.0