Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Adds source-map=directory support #964

Merged
merged 2 commits into from
May 19, 2015
Merged

CLI: Adds source-map=directory support #964

merged 2 commits into from
May 19, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented May 17, 2015

  • For multi-file compilation.

  • Written test.

  • Usage:

    node-sass --source-map source-map/dir --output css/path style/src/

Issue URL: #903.
PR URL: #964.

xzyfer
xzyfer reviewed May 18, 2015
View reviewed changes
bin/node-sass
return emitter.emit('error', 'No input file was found.');
}

if (options.sourceMap) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@xzyfer
Copy link
Contributor

xzyfer commented May 18, 2015

Seems legit. Update the readme please.

@am11
CLI: Adds source-map=directory support.
1c65c53 
* For multi-file compilation.
* Written test.
* Usage:

  ```javascript
  node-sass --source-map source-map/dir --output css/path style/src/
  ```

Issue URL: sass#903.
PR URL: sass#964.
@am11 am11 changed the title CLI: Adds source-map support CLI: Adds source-map=directory support May 18, 2015
@am11
Copy link
Contributor Author

am11 commented May 18, 2015

Updated docs and removed the nit. 🎱

@kkopachev kkopachev mentioned this pull request May 18, 2015
Merged
am11 added a commit that referenced this pull request May 19, 2015
@am11
Merge pull request #964 from am11/master
23e6282 
CLI: Adds source-map=directory support
@am11 am11 merged commit 23e6282 into sass:master May 19, 2015
@am11 am11 mentioned this pull request May 19, 2015
Closed
@xzyfer
Copy link
Contributor

xzyfer commented May 19, 2015

Nice work @am11

@xzyfer xzyfer modified the milestones: next.minor, next.patch May 19, 2015
@xzyfer xzyfer modified the milestones: next.patch, v3.1.2 Jun 10, 2015
@am11 am11 mentioned this pull request Jul 10, 2015
Closed
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
@am11
SourceMap: Fixes relative file path issue.
8f36c75 
Issue URL: sass#764.
PR URL: sass#964.
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
@xzyfer
Merge pull request sass#964 from am11/master
62314f6 
Fixes sourcemaps relative file path issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature - Implementation Module - CLI
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@am11 @xzyfer