Responsive bar icon #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarioRicalde
commented
Oct 13, 2013
MarioRicalde
commented
The reasoning behind removing the inline shadow is that it's uneeded. It's a distraction, and the overall theme wants to go the flat route. The reasoning behind making the stripe smaller, is that when it's too tall it's distracting, also 0.5 em seems to be a bit too much, especially when compared against the logo thicker part ( 8px ). I've lowered it to half of that 0.22em ~= 4px.
Using the border color (iron) on an already iron backgorund makes it pretty hard to see.
jina
pushed a commit
that referenced
this pull request
Oct 14, 2013
"Responsive bar icon" I liked the subtlety but it's probably better more visible. Thanks!
nex3
pushed a commit
that referenced
this pull request
Jun 23, 2023
More consistent use of typogr for all contents.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
More consistent use of typogr for all contents.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
More consistent use of typogr for all contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.