[docs] Sticky Navigation #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina
requested changes
Sep 30, 2019
jina
approved these changes
Oct 7, 2019
|
Are we good to merge this? |
|
I'll go ahead and merge. Going forward, do we want to have the code committer merge after approval, the approver, or just whoever gets to it first? I've been on some teams that have the code committer do it. We never really discussed what our ideal workflow would be for the website. 😄 |
|
This is what I've been doing:
|
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
* [docNav] Moved h3 title into nav wrapper * [docNav] Init styles for doc navigation component * [docNav] Import doc navigation component into sass.css.scss * [docNav] Functional to make doc navigation sticky on scroll * [docNav] Rename js class name and changed from single to double quotes * [docNav] Change class name to sl-js-nav--is-sticky * [docNav] renamed doc-navigation to navigation and removed nesting * [docNav] renamed doc-navigation to navigation * [docNav] Added carriage return after h3
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
* [docNav] Moved h3 title into nav wrapper * [docNav] Init styles for doc navigation component * [docNav] Import doc navigation component into sass.css.scss * [docNav] Functional to make doc navigation sticky on scroll * [docNav] Rename js class name and changed from single to double quotes * [docNav] Change class name to sl-js-nav--is-sticky * [docNav] renamed doc-navigation to navigation and removed nesting * [docNav] renamed doc-navigation to navigation * [docNav] Added carriage return after h3
Friendly-users
added a commit
to Friendly-users/sass-site
that referenced
this pull request
Jun 27, 2024
----- It is inappropriate to include political and offensive content in public code repositories. Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment. Please refrain from adding such content to public code repositories. --- sass#300 sass#301 sass#302 sass#303 sass#304 sass#305 sass#306 sass#307 sass#308 sass#309 sass#310 sass#311 sass#312 sass#313 sass#314 sass#315 sass#316 sass#317 sass#318 sass#319 sass#320 sass#321 sass#322 sass#323 sass#324 sass#325 sass#326 sass#327 sass#328 sass#329 sass#330 sass#331 sass#332 sass#333 sass#334 sass#335 sass#336 sass#337 sass#338 sass#339 sass#340 sass#341 sass#342 sass#343 sass#344 sass#345 sass#346 sass#347 sass#348 sass#349 sass#350 sass#351 sass#352 sass#353 sass#354 sass#355 sass#356 sass#357 sass#358 sass#359 sass#360 sass#361 sass#362 sass#363 sass#364 sass#365 sass#366 sass#367 sass#368 sass#369 sass#370 sass#371 sass#372 sass#373 sass#374 sass#375 sass#376 sass#377 sass#378 sass#379 sass#380 sass#381 sass#382 sass#383 sass#384 sass#385 sass#386 sass#387 sass#388 sass#389 sass#390 sass#391 sass#392 sass#393 sass#394 sass#395 sass#396 sass#397 sass#398 sass#398 sass#399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Made the documentation navigation sticky when user scrolls down the page.
Screenshot:
Closes #268