[hotfix-400] Fix guide page scss/sass toggle #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Nov 7, 2019
|
Thanks for tracking this down! |
|
@nex3 np! Does the changes get deploy once PRs are merged? I didn't see the error locally so I want to test and see if I fixed the problem. |
|
Yeah, they're automatically deployed—I can confirm that this patch has been deployed but also that the issue is still present in the live code website. |
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The scss/sass toggle was broken because of this error:
To fix this issue, I made the function in
navigation.jsto anonymous function.Closes #400