Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide page scss/sass toggle doesn't work #400

Closed
RileyMShea opened this issue Nov 2, 2019 · 8 comments · Fixed by #404
Closed

guide page scss/sass toggle doesn't work #400

RileyMShea opened this issue Nov 2, 2019 · 8 comments · Fixed by #404
Labels
bug

Comments

@RileyMShea
Copy link

https://sass-lang.com/guide

just jumps down the page when trying to toggle between sass and scss examples
@nex3
Copy link
Contributor

nex3 commented Nov 4, 2019

@adekunleoduye Can you investigate? This sounds similar to the other switcher issues that were happening due to the sticky nav code.

@adekunleoduye
Copy link
Member

@nex3 yeah, I can take a look at it.

@nex3
Copy link
Contributor

nex3 commented Nov 5, 2019

Thanks!

@RileyMShea
Copy link
Author

As far as I can tell the site has been this way since October 13th. It also seems present in the rest of the general documentation outside the introductory guide.

Same issues in the Oct 13th snapshot

Latest date where it's working as intended seems to be the Oct 3rd snapshot.

@adekunleoduye adekunleoduye mentioned this issue Nov 7, 2019
Merged
@nex3 nex3 closed this as completed in #404 Nov 7, 2019
@nex3 nex3 mentioned this issue Nov 7, 2019
Closed
@nex3 nex3 reopened this Nov 7, 2019
@nex3
Copy link
Contributor

nex3 commented Nov 7, 2019

@adekunleoduye It looks like this is still reproducing... maybe we should roll back sticky navs until we can get it working again?

@adekunleoduye
Copy link
Member

@nex3 yeah, that sounds good to me.

@adekunleoduye adekunleoduye mentioned this issue Nov 8, 2019
Closed
@nex3
Copy link
Contributor

nex3 commented Nov 8, 2019 •
edited
Loading

This has been temporarily fixed by #408; we still need to figure out why the upgrade caused problems and perhaps why they only seemed to show up in production.

@nex3 nex3 added the bug label Jun 7, 2022
@nex3
Copy link
Contributor

nex3 commented Apr 11, 2023

Closing this out since we plan to move to a totally new site infrastructure anyways so it's unlikely we can roll forward sticky nav code as-is regardless.

@nex3 nex3 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
Friendly-users added a commit to Friendly-users/sass-site that referenced this issue Jun 27, 2024
@Friendly-users
No politics or offense in public code.
9cc5212 
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
---

 sass#400 sass#401 sass#402 sass#403 sass#404 sass#405 sass#406 sass#407 sass#408 sass#409 sass#410 sass#411 sass#412 sass#413 sass#414 sass#415 sass#416 sass#417 sass#418 sass#419 sass#420 sass#421 sass#422 sass#423 sass#424 sass#425 sass#426 sass#427 sass#428 sass#429 sass#430 sass#431 sass#432 sass#433 sass#434 sass#435 sass#436 sass#437 sass#438 sass#439 sass#440 sass#441 sass#442 sass#443 sass#444 sass#445 sass#446 sass#447 sass#448 sass#449 sass#450 sass#451 sass#452 sass#453 sass#454 sass#455 sass#456 sass#457 sass#458 sass#459 sass#460 sass#461 sass#462 sass#463 sass#464 sass#465 sass#466 sass#467 sass#468 sass#469 sass#470 sass#471 sass#472 sass#473 sass#474 sass#475 sass#476 sass#477 sass#478 sass#479 sass#480 sass#481 sass#482 sass#483 sass#484 sass#485 sass#486 sass#487 sass#488 sass#489 sass#490 sass#491 sass#492 sass#493 sass#494 sass#495 sass#496 sass#497 sass#498 sass#498 sass#499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hotfix-400] Fix guide page scss/sass toggle adekunleoduye/sass-site
3 participants
@nex3 @adekunleoduye @RileyMShea