Document configuring through imports #425
Conversation
|
|
||
| <% impl_status dart: '1.24.0', libsass: false, ruby: false %> | ||
|
|
||
| You can configure modules that are loaded through an `@import` simply by |
There was a problem hiding this comment.
Try to avoid words like "just" and "simply"—they can feel patronizing for some readers.
Also, link "configure modules" to the section describing how default variables work. Users reading this may not have the context to understand exactly what kind of "configuration" you're referring to.
| defining global variables prior the `@import` that first loads that module. | ||
|
|
||
| Note that changes to the configuration after the module is first loaded will be | ||
| ignored. |
There was a problem hiding this comment.
I find this kind of confusing. Either elaborate on it by describing exactly the situation in which this might be a problem (possibly within a <% heads_up do %> block), or leave it out if you don't think it's likely to be a substantial problem in practice.
| $lib-color: red; | ||
| @import "library"; |
There was a problem hiding this comment.
I think this is just going to produce more net confusion. Examples on the doc site don't have to be 100% comprehensive (that's what the spec is for), so it's more important that they show the most focused version of a feature possible.
| Modules are only loaded once, so if you change the configuration after you | ||
| `@import` a module for the first time (even indirectly), the change will be | ||
| ignored if you `@import` the module again. |
There was a problem hiding this comment.
Nit: indent this two spaces.
jathak
force-pushed
the
import-configuration
branch
from
b2a275b
to
f55ea77
Compare
No description provided.