Fix jump in navigation toggle animation #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dustinhorton Sorry about the delayed merge. Had a busy couple weeks with job changes and such. Thanks so much for doing that screencast — it's super helpful in seeing how the change helps! :) |
jina
pushed a commit
that referenced
this pull request
Dec 19, 2013
Fix jump in navigation toggle animation
|
@jina No sweat, & congrats on the new gig! |
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Automated dependency upgrades
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Fix jump in navigation toggle animation
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Automated dependency upgrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the
paddingfrom.navigation, the element being animated, to an interior element, we can avoid the jump at the end of the navigation toggle.Screencast comparing navs: http://f.cl.ly/items/463t401X0n3K1X2D1O1o/Screeny%20Video%20Nov%2029,%202013,%202.13.20%20AM.iphone.mp4