Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make @extend less prominent #489

Closed
wants to merge 2 commits into from
Closed

Make @extend less prominent #489

wants to merge 2 commits into from

Conversation

Awjin
Copy link
Contributor

@Awjin Awjin commented Oct 8, 2020 •
edited
Loading

The "Learn Sass" page still promotes @extend. This decreases @extend visibility in favor of @mixin, in line with modern best practices.

Closes #473

@Awjin Awjin requested a review from nex3 October 8, 2020 17:16
@nex3
Copy link
Contributor

nex3 commented Oct 8, 2020

I don't think I'm ready to discourage the use of @extend yet. Especially in the context of the module system, its behavior is much less global than it's been historically, and I want to give the ecosystem a chance to adapt to that.

@Awjin
Copy link
Contributor Author

Awjin commented Oct 8, 2020

Fair enough. I'll close this out for now

@Awjin Awjin closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 Awaiting requested review from nex3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve mixin and extend docs in https://sass-lang.com/guide
2 participants
@Awjin @nex3