use the ~ operator instead of = to fix bad <code> block indentation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was noticing that too. I think we can override and come up with a code highlighting theme that matches the website a bit more and provides more contrast. I just don't think anybody has done it yet. |
bpainter
added a commit
that referenced
this pull request
Oct 11, 2013
use the ~ operator instead of = to fix bad <code> block indentation
bpainter
added a commit
that referenced
this pull request
Oct 11, 2013
There isn't enough contrast between the code blocks and the code. Adjusted the opacity to increase contrast. We can readjust later once we get a chance to create some Sassy code block related color treatment. This is a temporary fix to #5.
nex3
pushed a commit
that referenced
this pull request
Jun 23, 2023
Add homepage, global navigation, get involved, community guidelines, and install pages.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Add homepage, global navigation, get involved, community guidelines, and install pages.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Add homepage, global navigation, get involved, community guidelines, and install pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jina This fixes the strange indentation of the code block output. Something that I am noticing about the Rouge::Themes::Base16::Solarized business that is formatting/styling code blocks... is that there is pretty poor contrast on some of the elements. Particularly the orange and green are really low contrast and then the dark for the .err class generated, that has a low text/background contrast... but a really jarring high contrast against the main pre.highlight background. Any objections to specifying style overrides for those cases to improve the visibility and general feeling of this stuff? Is there a better way to access the styles in the magic provided by the library we are using for code formatting/styling?
cc/ @bpainter