Add href to compatibility callout toggle #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nex3: Can you deploy this branch so we can confirm it works? I'm having trouble getting the site to build locally. |
|
It looks like this substantially changes the look of the button, and also breaks the on-click behavior. You may need to load the site locally to debug this—let me know if I can help you debug any issues that come up.
|
This will ensure browsers allow the toggles to be tabbed to. Fixes #598.
jathak
changed the title
nex3
requested changes
Jul 18, 2022
nex3
approved these changes
Aug 2, 2022
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
This will ensure browsers allow the toggles to be tabbed to. Fixes sass#598.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
This will ensure browsers allow the toggles to be tabbed to. Fixes sass#598.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598.