Use precision 10 for specs by default. #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xzyfer It looks like changing the default precision is causing libsass to produce different colors for some reason. Can you take a look? |
|
Think the upstream issue is sass/libsass#2294 |
|
@mgreter Changing the precision that's used for Sass arithmetic shouldn't affect the colors from color functions, but it does. I think this is a LibSass bug, and it's blocking my ability to land this pull request without marking tons of specs as TODO for LibSass. Can you look into fixing that? |
|
@mgreter ping? |
LibSass doesn't seem to correctly handle numbers at the far end of precision. See sass/libsass#3788
|
Since there hasn't been any response from the LibSass folks on this, I guess I'll just mark those specs as TODO. |
jmesserly
approved these changes
Dec 12, 2018
glebm
added a commit
to glebm/sass-spec
that referenced
this pull request
Dec 15, 2018
Follow-up to sass#1132 I'm guessing these weren't caught because of warning todos (failures are ignore with probe-todo that runs on CI, even though it's just a warning todo).
xzyfer
pushed a commit
that referenced
this pull request
Dec 16, 2018
Follow-up to #1132 I'm guessing these weren't caught because of warning todos (failures are ignore with probe-todo that runs on CI, even though it's just a warning todo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#1122
[skip dart-sass]