Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with handling / in interpolation #2160

Closed
xzyfer opened this issue Oct 4, 2016 · 1 comment
Closed

Bug with handling / in interpolation #2160

xzyfer opened this issue Oct 4, 2016 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@xzyfer
Copy link

xzyfer commented Oct 4, 2016

@nex3 confirmed this is a bug. There is currently a sass spec asserting this broken behaviour which is causing LibSass to fail CI.

h1 {
  delayd: #{5% / 2};
  delayd: #{+5% / 2};
  evaled: #{-5% / 2};
}

Sass 3.4.21

h1 {
  delayd: 5%/2;
  delayd: 5%/2;
  evaled: -2.5%;
}

Expected

h1 {
  delayd: 5%/2;
  delayd: 5%/2;
  evaled: -5%/2;
}
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 4, 2016
This behaviour is a bug in Sass (sass/sass#2160) that LibSass does
not have. There isn't a straight forward for LibSass to implement
this broken behaviour and it's breaking CI blocking 3.4.
xzyfer added a commit to xzyfer/sass that referenced this issue Oct 6, 2016
xzyfer added a commit to xzyfer/sass that referenced this issue Oct 7, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 7, 2016
This updates the interpolation-operators-precedence to match the
behaviour expected by sass/sass#2160.

This will need a sanity check by @nex3
xzyfer added a commit to xzyfer/sass that referenced this issue Oct 7, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 7, 2016
This updates the interpolation-operators-precedence to match the
behaviour expected by sass/sass#2160.

This will need a sanity check by @nex3
xzyfer added a commit to xzyfer/sass that referenced this issue Oct 8, 2016
xzyfer added a commit to xzyfer/sass that referenced this issue Oct 8, 2016
xzyfer added a commit to xzyfer/sass that referenced this issue Oct 8, 2016
I had a quick chat to @nex3 which pointed me to the lexer/parse
as the root cause of the observed inconsistencies.

I think the general approach is sound. I'm sure the implementation
could be tidied up.

Fixes sass#2160
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 8, 2016
This updates the interpolation-operators-precedence to match the
behaviour expected by sass/sass#2160.

This will need a sanity check by @nex3
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 8, 2016
LibSass is no more or less inconsistent than Ruby Sass, but it is
different. LibSass will address the differences to Ruby Sass when
sass/sass#2160 is resolved.
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 8, 2016
This updates the interpolation-operators-precedence to match the
behaviour expected by sass/sass#2160.

This will need a sanity check by @nex3
@nex3 nex3 added the bug Something isn't working label Dec 11, 2016
@nex3
Copy link
Contributor

nex3 commented Apr 6, 2018

I'm moving this issue to the new Ruby Sass repository because it's specific to Ruby Sass's implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants