Support sprockets-rails 3 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprockets-rails 3 will build the sprockets environment only in a after_initialize block so app.assets is never defined in a railtie initializer.
|
I haven’t tested this code, but it looks good. Nice work. |
|
@bolandrm WDYT about this? |
|
Any news on this? It seems I cannot use sprockets-rails v3 without these changes (even if some other stuff then breaks, but that is due to other gems). |
This was referenced Jan 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sprockets-rails 3 will support both Sprockets 3 and Sprockets 4 and also introduce new features only present on Sprockets 3.
I changed this gem to work with sprockets-rails 3.