Remove dependency on full Rails #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`railties` has most of Rails dependencies and will not depend on `activerecord` for example. Since we use Sequel rather than ActiveRecord, requiring sassc was the culprit for adding activerecord to the bundle for no good reason.
|
Hey, thanks for the PR. Looks like there are some version related test failures. |
|
I don't think the errors are related to my changes. I followed the commands displayed in the travis-ci log and omitted the part that pulls from this PR and I got exactly the same errors. |
|
Builds for rails 4.2 are failing because sprockets-rails 3.0 is installed only in 4.2 builds and we need rafaelfranca@c85db78 in #41 to pass tests with sprockets-rails 3.0. |
|
Thanks! |
bolandrm
added a commit
that referenced
this pull request
Jan 20, 2016
Remove dependency on full Rails
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
railtieshas most of Rails dependencies and will not depend onactiverecordfor example. Since we use Sequel rather than ActiveRecord, requiring sassc was the culprit for adding activerecord to the bundle for no good reason.