Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silence_deprecation option to #register_engine #73

Closed
wants to merge 1 commit into from
Closed

Add silence_deprecation option to #register_engine #73

wants to merge 1 commit into from

Conversation

rosylilly
Copy link

@bobmaerten
Copy link

You should look for @schneems changes on sass-rails
https://github.com/rails/sass-rails/pull/382/files

@schneems
Copy link
Contributor

I actually made the PR that added those register_engine calls in this lib, if you blame the file it goes back to me.

This change is needed to get Sprockets 3.7.0+ to run with no deprecations. I released 3.7.0 after I made this change to sassc-ruby.

The reason this PR is failing is that Sprockets 2 (which this gem supports) doesn't accept a hash as a third argument. You can see the docs for supporting Sprockets 2, 3, and 4 here https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#registering-all-versions-of-sprockets-in-processors

It's a little cleaner than my PR to sass-rails.

@bolandrm
Copy link
Member

bolandrm commented Aug 1, 2016

Closing - resolved by #76 - thanks for the PR.

@bolandrm bolandrm closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants