Silene Sprockets deprecation message #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on it on #77 once i'm done you can rebase against master and your tests should pass. |
|
@kinopyo Could you please rebase now? |
kinopyo
force-pushed
the
deprecation-register-engine
branch
from
4844a81
to
d9ea930
Compare
|
rebased and CI passed 🎈 👏 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is a PR already trying to solve the issue but seems like failing for CI.
Hope this PR can silence deprecation while satisfying different versions of Sprockets, adopting the tips shared by @schneems in this comment.
CI Build
The CI build failed but seems like master is already broken(?), and these 2 look like identical, at least this sprockets 2 were passed which failed on #73.
Related issue: #75