Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffi dependency #100

Closed
morgoth opened this issue Jan 14, 2019 · 7 comments
Closed

Update ffi dependency #100

morgoth opened this issue Jan 14, 2019 · 7 comments

Comments

@morgoth
Copy link

morgoth commented Jan 14, 2019

ffi gem released version 1.10.
Can the sassc gem dependency be relaxed to include this release? https://github.com/ffi/ffi/blob/master/CHANGELOG.md#1100--2019-01-06

@aried3r
Copy link

aried3r commented Jan 14, 2019

There's also already a (closed) PR for this! #99.

@bolandrm
Copy link
Member

completed #102

@ut
Copy link

ut commented Feb 22, 2019

IMO the dependency has not been relaxed enough, PR #102 contains

spec.add_dependency "ffi", "~> 1.9"

but current FFI version is 1.10

(FFI 1.10 is required by to others gems (like rb-inotify) which breaks my bundle install)

@aried3r
Copy link

aried3r commented Feb 26, 2019

@ut, ~> 1.9 will also match 1.10. Indeed it's the same as ['>= 1.9', '< 2.0'] if I'm not mistaken. The only thing missing is a release with this change.

@bolandrm
Copy link
Member

2.0.1, which includes this change, was released this morning

@aried3r
Copy link

aried3r commented Feb 26, 2019

Oh, I didn't check for updates today so far, good to know. Thanks for the release!

@ut
Copy link

ut commented Feb 26, 2019

Thanks @aried3r for the info, thanks @bolandrm for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants