Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy global load path from sass #113

Merged
merged 1 commit into from
May 8, 2019
Merged

copy global load path from sass #113

merged 1 commit into from
May 8, 2019

Conversation

michaelglass
Copy link
Contributor

adding support for SassC.load_paths and SASS_PATH to make it easier to migrate from Sass to SassC

@borama
Copy link

borama commented May 8, 2019

Just a context note: this will be a very welcome addition. After migrating to sassc, we have problems with slim-lint (the linter for the Slim templates), which cannot deal with relative SASS imports (@import 'lib/somefile') used in SASS blocks embedded in Slim templates any more. There is currently no way for the SASS load paths to be specified in slim-lint.

Before upgrading, we used the SASS_PATH env variable to globally set the SASS load path before running slim-lint and everything worked without issues, as this was supported in the sass-ruby gem itself. The same support would be very nice in sassc, too. Currently, we are trying the forked version with this PR merged, and all seems to work again nicely.

@bolandrm
Copy link
Member

bolandrm commented May 8, 2019

Thanks!

@bolandrm bolandrm merged commit e7da015 into sass:master May 8, 2019
@michaelglass michaelglass deleted the add-global-load-path branch May 13, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants