Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile for builds under MSYS/MinGW (Windows) #120

Merged
merged 2 commits into from Jul 15, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jul 14, 2015

Add step to build a hopefully fully portable libsass.dll!
Links gcc and stc++ libs statically into the dll itself!

This need sass/libsass#1344 merged first!

Add step to build a hopefully fully portable libsass.dll!
Links gcc and stc++ libs statically into the dll itself!
@mgreter mgreter force-pushed the feature/win-dll-build-mingw branch from 54142ee to d6f4e30 Compare July 14, 2015 20:51
@xzyfer
Copy link
Contributor

xzyfer commented Jul 14, 2015

I have no input on Makefile changes. Do what you think is best @mgreter 🚀

I only ask you make the requires upstream changes to the homebrew formula should they be needed.

@mgreter mgreter force-pushed the feature/win-dll-build-mingw branch 2 times, most recently from e752cfa to 101a218 Compare July 15, 2015 00:56
@mgreter
Copy link
Contributor Author

mgreter commented Jul 15, 2015

Wondered why the icon failed on linux until I figured out executables have no icons on linux 🐌

@mgreter mgreter force-pushed the feature/win-dll-build-mingw branch 5 times, most recently from 13143d9 to 105d376 Compare July 15, 2015 01:30
@mgreter mgreter force-pushed the feature/win-dll-build-mingw branch from 105d376 to ee93ff8 Compare July 15, 2015 01:36
mgreter added a commit that referenced this pull request Jul 15, 2015
Improve Makefile for builds under MSYS/MinGW (Windows)
@mgreter mgreter merged commit d6a05ae into sass:master Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants