Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing environment for CLI #172

Closed
DanPurdy opened this issue Sep 15, 2015 · 3 comments
Closed

Testing environment for CLI #172

DanPurdy opened this issue Sep 15, 2015 · 3 comments

Comments

@DanPurdy
Copy link
Member

It's become clear that our Travis setup isn't currently adequate for testing our CLI or more specifically the unreleased work we do on it.

The problem lies in the fact that Travis when provisioning is installing sass-lint globally for CLI testing purposes but this obviously means it's only installing it at the last released version which at the time of writing is 1.2.0.

Some of the work I've done for 1.2.1 #170 and 1.3.1 #152 is currently blocked with tests failing on Travis. Locally they are working fine but this is just because I've symlinked my globally installed sass-lint to my development copy.

This doesn't affect testing of non CLI work at all but is leading to quite a few false positives in the CLI tests.

Any thoughts on how to progress or how we'd like to modify our Travis setup.

@mven
Copy link
Contributor

mven commented Sep 15, 2015

As a temporary fix, do you think something like the following would work on Travis CI? It looks like it's working locally for me:

var command = path.resolve(__dirname, '../bin/sass-lint.js') + ' -h';

@DanPurdy
Copy link
Member Author

I'm open to all suggestions, personally I'd rather it wasn't code we add directly to sass-lint and we just get some way of making sure the CLI global install is up to date with development for testing, with pluggable rules on the cards I can see some fairly big core additions and CLI changes coming.

Definitely need to get this sorted soon though, 1.2.1 has a lot of very useful hotfixes in that we need to get out.

@DanPurdy
Copy link
Member Author

Nice one @mven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants