Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix master - Silence output on no errors #170

Merged
merged 4 commits into from
Sep 18, 2015

Conversation

DanPurdy
Copy link
Member

Silences error output when no warnings or errors are present in linted files. Also improves the handling of writing output to the file system with completion/error messages but no error thrown.

@Snugug - Im hoping this is what you were aiming for, I'll gladly update or revert this if it's not quite what was envisaged.

closes #141

DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com

@DanPurdy
Copy link
Member Author

Dont merge this yet, wanted to investigate CLI warnings too as this should break them temporarily

@DanPurdy
Copy link
Member Author

Closing for now, CLI testing on travis is definitely broken.

@DanPurdy DanPurdy closed this Sep 14, 2015
@DanPurdy DanPurdy removed this from the 1.2.1 milestone Sep 14, 2015
@DanPurdy DanPurdy reopened this Sep 14, 2015
@DanPurdy
Copy link
Member Author

@bgriffith @Snugug : Ok this confirms to me that the CLI isn't being tested properly, it's being loaded and tested at its latest release. 1.2.0 in this case it looks like. The changes we are making aren't being taken into account as far as the cli is concerned, we'll need to merge our changes into the globally installed sass-lint on Travis too in order to progress with this CLI development. Or at least symlink the global node modules folder to wherever we are cloning this repo to test.

@DanPurdy DanPurdy removed the on hold label Sep 16, 2015
@DanPurdy
Copy link
Member Author

Ok thanks to the addition @mven made, this is now ready for review @bgriffith @Snugug ready for a 1.2.1 release.

@DanPurdy DanPurdy added this to the 1.2.1 milestone Sep 16, 2015
@bgriffith
Copy link
Member

👍

bgriffith added a commit that referenced this pull request Sep 18, 2015
Hotfix master - Silence output on no errors
@bgriffith bgriffith merged commit edd7877 into sasstools:master Sep 18, 2015
donabrams pushed a commit to donabrams/sass-lint that referenced this pull request Nov 19, 2015
Hotfix master - Silence output on no errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants