Add format and output options to CLI #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Wanted to debug travis mainly here with a build.
|
Test failing could be to do with the issue in #151, i doubt it very much but will wait to fix this once that has been merged in. |
|
Looking at the Travis output, it's installing sass-lint globally at 1.2.0, is the current branch getting merged into that? If not that will be the reasons for the test failing as the new functionality doesn't exist.. |
|
Now also closes #181 Added another test case and fixed the failing tests. |
|
Looks good. |
bgriffith
added a commit
that referenced
this pull request
Sep 18, 2015
Add format and output options to CLI
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Add format and output options to CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 new flags to the CLI
-f --format [format]-o --output [output]This makes the CLI feature complete compared to the current
sass-lintbuild. Format allows you to specify an output format from any of the eslint formatters. Output allows you to specify and output directory & file to write linting results to.Also added tests for each option.
There's a slight overlap in some of the files added here as in #151 which should probably be merged first due to it fixing bugs.
closes #127
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com