-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename default config file #533
Comments
I'm open to it if others are? |
I'm ok to allow it. Original name was following scss lint convention.
|
Do you want a PR for this? |
If we allow it alongside .sass-lint.yml (we should) then a PR would be fine, would this file be of json syntax or would it stick with YML? If we remove the .sass-lint.yml then it'll be a v2 thing for sure. |
I think that's preferable to keep both (for now at least).
|
Yeah, hence why i'm keen to keep it 👍 I'm happy for a PR to be done. You may want to hold off until #495 is merged into develop though as it's possible that few things will change alongside it but it wouldn't cause any issue if you don't want to wait. |
I've got several tests failing after a fresh install: http://pastebin.com/yRVvjvvm. I'm on Do you have any idea? |
Looks like you're missing a global version of sass-lint |
I'm curious, shouldn't you test against local code in |
Sorry i just gave you the exact wrong information! Basically go into your project root for sass-lint and do this sets your local copy of sass-lint as your global one so all your changes will tested so you should uninstall your global sass-lint first! |
No problem :) var command = '../bin/sass-lint.js'; |
Yeah, I think we actually started with that I can't remember why it changed.. |
Perhaps initial versions were missing shebang. Anyway this is working now. |
Released in 1.12.0 |
Hi,
I think it could be a good idea to rename or at least offer an alternative name :
.sasslintrc
.The reason is that most tools use this convention and it feels good to know that
*rc
files are for tools :)The text was updated successfully, but these errors were encountered: