Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default config file #533

Closed
ngryman opened this issue Feb 16, 2016 · 14 comments
Closed

Rename default config file #533

ngryman opened this issue Feb 16, 2016 · 14 comments

Comments

@ngryman
Copy link
Contributor

ngryman commented Feb 16, 2016

Hi,

I think it could be a good idea to rename or at least offer an alternative name : .sasslintrc.
The reason is that most tools use this convention and it feels good to know that *rc files are for tools :)

@DanPurdy
Copy link
Member

I'm open to it if others are?

@Snugug
Copy link
Member

Snugug commented Feb 16, 2016

I'm ok to allow it. Original name was following scss lint convention.

On Feb 16, 2016, at 5:58 PM, Dan Purdy notifications@github.com wrote:

I'm open to it if others are?


Reply to this email directly or view it on GitHub.

@ngryman
Copy link
Contributor Author

ngryman commented Feb 16, 2016

Do you want a PR for this?

@DanPurdy
Copy link
Member

If we allow it alongside .sass-lint.yml (we should) then a PR would be fine, would this file be of json syntax or would it stick with YML?

If we remove the .sass-lint.yml then it'll be a v2 thing for sure.

@ngryman
Copy link
Contributor Author

ngryman commented Feb 17, 2016

I think that's preferable to keep both (for now at least).

.sasslintrc would just be an alias, so yes it should definitively have the same format. Furthermore, yml is perfectly fine and pretty common in the sass community.

@DanPurdy
Copy link
Member

Yeah, hence why i'm keen to keep it 👍

I'm happy for a PR to be done. You may want to hold off until #495 is merged into develop though as it's possible that few things will change alongside it but it wouldn't cause any issue if you don't want to wait.

@ngryman
Copy link
Contributor Author

ngryman commented Feb 17, 2016

I've got several tests failing after a fresh install: http://pastebin.com/yRVvjvvm.

I'm on os x el capitan
I tested with node 4 & 5.

Do you have any idea?

@DanPurdy
Copy link
Member

npm install sass-lint -g first

Looks like you're missing a global version of sass-lint

@ngryman
Copy link
Contributor Author

ngryman commented Feb 17, 2016

I'm curious, shouldn't you test against local code in bin/sasslint.js? How do you test your current changes to cli?

@DanPurdy
Copy link
Member

Sorry i just gave you the exact wrong information!

Basically go into your project root for sass-lint and do npm link

this sets your local copy of sass-lint as your global one so all your changes will tested so you should uninstall your global sass-lint first! npm uninstall -g sass-lint

@ngryman
Copy link
Contributor Author

ngryman commented Feb 17, 2016

No problem :)
That said, a less tricky solution might be to simply execute bin/sass-lint.js in tests:

var command = '../bin/sass-lint.js';

@DanPurdy
Copy link
Member

Yeah, I think we actually started with that I can't remember why it changed..

@ngryman
Copy link
Contributor Author

ngryman commented Feb 17, 2016

Perhaps initial versions were missing shebang. Anyway this is working now.
Thanks.

@DanPurdy
Copy link
Member

DanPurdy commented Oct 3, 2017

Released in 1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants