Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .sasslintrc #537

Closed
wants to merge 1 commit into from
Closed

Add support for .sasslintrc #537

wants to merge 1 commit into from

Conversation

ngryman
Copy link
Contributor

@ngryman ngryman commented Feb 17, 2016

Related: #533.

ngryman
ngryman reviewed Feb 17, 2016
View reviewed changes
lib/config.js
@@ -19,7 +19,7 @@ var findFile = function findFile (configPath, filename) {

configPath = configPath || path.join(process.cwd(), filename);

if (fs.existsSync(configPath)) {
if (fs.existsSync(configPath) && fs.statSync(configPath).isFile()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if it's a file. My tests add a .sass-lint.yml directory and were failing because of this.
I think it's a good sanity check anyway.

@benthemonkey
Copy link
Member

In the discussions it sounds like the agreed-upon name of the file was .sasslintrc (you even mention that in your comments). Why, then, does the code use .sassrc? Perhaps that's a typo?

@ngryman
Copy link
Contributor Author

ngryman commented Feb 19, 2016

@benthemonkey Yup that was a typo, thanks :)

@bgriffith
Copy link
Member

Hey - could you add a Developer Certificate of Origin

@ngryman
Copy link
Contributor Author

ngryman commented Feb 21, 2016

DCO 1.1 Signed-off-by: Nicolas Gryman ngryman@gmail.com

@jankanty
Copy link

jankanty commented Mar 3, 2016

I'll be very happy if it will come in next update 😄

@bgriffith
Copy link
Member

Hey @ngryman - Could you update this branch with the latest code on develop and fix any conflicts? Thanks.

@ngryman
Copy link
Contributor Author

ngryman commented May 21, 2016

Hey, I submitted this 3 months ago.
If the codebase has changed so much, I think one of you guys is better placed to do this no?
I don't know the project enough to do this quickly.
Thanks!

@DanPurdy DanPurdy mentioned this pull request Jun 22, 2016
Closed
@DanPurdy
Copy link
Member

Im continuing this work in #755 thanks @ngryman for getting this started, sorry it's taken us so long to get around to it but we wanted to fix a lot of other stuff before adding this functionality.

@DanPurdy DanPurdy closed this Jun 22, 2016
@DanPurdy DanPurdy mentioned this pull request Sep 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ngryman @benthemonkey @bgriffith @jankanty @DanPurdy